Enable numeric-prefix identifiers for Databricks dialect#2290
Open
funcpp wants to merge 1 commit intoapache:mainfrom
Open
Enable numeric-prefix identifiers for Databricks dialect#2290funcpp wants to merge 1 commit intoapache:mainfrom
funcpp wants to merge 1 commit intoapache:mainfrom
Conversation
Databricks, built on Spark SQL, allows identifiers that start with digits. The Spark SQL ANTLR lexer defines IDENTIFIER as (UNICODE_LETTER | DIGIT | '_')+, with no restriction on the first character. Enable the existing supports_numeric_prefix() for DatabricksDialect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
supports_numeric_prefix()forDatabricksDialectDatabricks is built on Spark SQL, whose ANTLR lexer defines identifiers without restricting the first character:
This allows table names like
catalog.schema.1st_tableto parse correctly. Without this flag,.1inschema.1st_tableis tokenized as a decimal literal.Test plan
catalog.schema.1st_table,a.b.1csqlparser_common.rsautomatically include Databricks viaall_dialects_where